Closed
Conversation
30ce6b3 to
2c126e8
Compare
2c126e8 to
6fa020a
Compare
6fa020a to
c6dd22d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable API Security by default.
In case of an HTTP event:
pathto theurl. (http.url_details.pathis a backend tag that should not be set by the tracer. Currently, it always ends up having the value/overwritten from thehttp.urlhaving no path)span.kind: servertag{method} {route}. The same as for all instrumented frameworks.Motivation
I am trying to make Appsec API security work with lambda inside the tracer. To do this, the backend must recognize that the service represented by the lambda has an endpoint.
Testing Guidelines
Updating existing tests
Additional Notes
Changing the resource name might break other parts of the lambda integration that I am not aware of. This is maybe a case where this should be changed in the backend.
Types of Changes
Check all that apply